Urgh, this was an unfortunate off-by-one post:
I am deferring this patch until after Linaro's 2019.03 firmware
release and cherry-picking it into that. There must be a better way to
solve this.
My comment referred to "Hisilicon/D06: Drop the leading 0 (0x0 ->
0x)", which will be pushed with an improved subject.
/
Leif
On Thu, Mar 21, 2019 at 05:52:18PM +0000, Leif Lindholm wrote:
> I will update the subject line to reflect what is actually being
> changed.
>
> Other than that,
> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
>
>
> On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote:
> > From: Jason Zhang <zhangjinso...@huawei.com>
> >
> > BmcWdtEnable is a field of OemConfigData structure, need have
> > runtime service attribution if use it during exit boot service
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ming Huang <ming.hu...@linaro.org>
> > ---
> > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +-
> > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr
> > b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr
> > index 470e9ace3dcf..08236704fbfe 100644
> > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr
> > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr
> > @@ -23,7 +23,7 @@ formset
> > help = STRING_TOKEN(STR_OEM_CONFIG),
> > classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds.
> > efivarstore OEM_CONFIG_DATA,
> > - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > EFI_VARIABLE_NON_VOLATILE,
> > + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS,
> > name = OemConfig,
> > guid = gOemConfigGuid;
> >
> > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c
> > b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c
> > index 012d45bc0214..6668103af027 100644
> > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c
> > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c
> > @@ -316,7 +316,7 @@ OemConfigUiLibConstructor (
> > Status = gRT->SetVariable (
> > OEM_CONFIG_NAME,
> > &gOemConfigGuid,
> > - EFI_VARIABLE_NON_VOLATILE |
> > EFI_VARIABLE_BOOTSERVICE_ACCESS,
> > + EFI_VARIABLE_NON_VOLATILE |
> > EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,
> > sizeof (OEM_CONFIG_DATA),
> > &Configuration
> > );
> > --
> > 2.9.5
> >
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
