Reviewed by Qian Yi<yi.q...@intel.com>

Thanks
Qian Yi

> -----Original Message-----
> From: Sun, Zailiang
> Sent: Friday, March 29, 2019 3:13 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david....@intel.com>; Qian, Yi <yi.q...@intel.com>
> Subject: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017]
> Vlv2TbltDevicePkg: Fix issue with SOURCE_DEBUG_ENABLE
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1671
> 
> Build fails when SOURCE_DEBUG_ENABLE is set to TRUE. This is due to
> limited size of FV MAIN region. To work around the issue, we increase size
> for the region by another 320KB provided that MINNOW2_FSP_BUILD is set
> to FALSE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zailiang Sun <zailiang....@intel.com>
> Cc: David Wei <david....@intel.com>
> Cc: Yi Qian <yi.q...@intel.com>
> ---
>  Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> index 4c19f156ea..84e3014178 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> @@ -47,8 +47,13 @@ DEFINE FLASH_REGION_AZALIABIN_BASE
> = 0xFFD08000
> 
>  !endif
> 
> +!if $(MINNOW2_FSP_BUILD) == TRUE
>  DEFINE FLASH_REGION_FVMAIN_OFFSET                             = 0x00110000
>  DEFINE FLASH_REGION_FVMAIN_SIZE                               = 0x00210000
> +!else
> +DEFINE FLASH_REGION_FVMAIN_OFFSET                             = 0x000C0000
> +DEFINE FLASH_REGION_FVMAIN_SIZE                               = 0x00260000
> +!endif
> 
>  DEFINE FLASH_REGION_FV_RECOVERY2_OFFSET                       = 0x00320000
>  DEFINE FLASH_REGION_FV_RECOVERY2_SIZE                         = 0x00070000
> --
> 2.19.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to