Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu
> -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, April 01, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: > Remove .S files > > .nasm file has been added for X86 arch. .S assembly code > is not required any more. > https://bugzilla.tianocore.org/show_bug.cgi?id=1594 > > Cc: Hao Wu <hao.a...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > .../Ia32/IntHandler.S | 28 ------------------- > .../PeCoffExtraActionLibDebug.inf | 2 -- > .../X64/IntHandler.S | 28 ------------------- > 3 files changed, 58 deletions(-) > delete mode 100644 > SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > delete mode 100644 > SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > deleted file mode 100644 > index 69c903788c..0000000000 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > +++ /dev/null > @@ -1,28 +0,0 @@ > -#------------------------------------------------------------------------------ > -# > -# Copyright (c) 2013, Intel Corporation. All rights reserved.<BR> > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD > License > -# which accompanies this distribution. The full text of the license may be > found at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# IntHandler.S > -# > -# Abstract: > -# > -# Assembly interrupt handler function. > -# > -#------------------------------------------------------------------------------ > - > -ASM_GLOBAL ASM_PFX(AsmInterruptHandle) > - > -.text > -ASM_PFX(AsmInterruptHandle): > - cli > - movb $1, %al > - iretl > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > index 1c52a000b0..fd56b8c94a 100644 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > +++ > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > @@ -35,12 +35,10 @@ > [Sources.IA32] > Ia32/IntHandlerFuncs.c > Ia32/IntHandler.nasm > - Ia32/IntHandler.S > > [Sources.X64] > X64/IntHandlerFuncs.c > X64/IntHandler.nasm > - X64/IntHandler.S > > [Packages] > MdePkg/MdePkg.dec > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > deleted file mode 100644 > index 108b40cf6d..0000000000 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > +++ /dev/null > @@ -1,28 +0,0 @@ > -#------------------------------------------------------------------------------ > -# > -# Copyright (c) 2013, Intel Corporation. All rights reserved.<BR> > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD > License > -# which accompanies this distribution. The full text of the license may be > found at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# IntHandler.S > -# > -# Abstract: > -# > -# Assembly interrupt handler function. > -# > -#------------------------------------------------------------------------------ > - > -ASM_GLOBAL ASM_PFX(AsmInterruptHandle) > - > -.text > -ASM_PFX(AsmInterruptHandle): > - cli > - movb $1, %al > - iretq > -- > 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
