On Thu, Jul 19, 2012 at 12:02 AM, Laszlo Ersek <ler...@redhat.com> wrote: > (CC'ing Richard Fontana) > > On 07/19/12 01:13, Jordan Justen wrote: >> On Wed, Jul 18, 2012 at 1:56 PM, Laszlo Ersek <ler...@redhat.com> wrote: >>> efifb (EFI frame buffer) doesn't work in RHEL-6.3 guests on RHEL-6.3 >>> qemu-kvm without the "pci=nocrs" guest kernel parameter. This is because >>> dynamic MMIO range allocation places the emulated Cirrus card's frame >>> buffer much lower than specified in the _CRS. Try to sync the related >>> bits. >>> >>> v1->v2: >>> - dropped most of v1 and started from scratch >>> - ASL / AML heavily based on SeaBIOS commit 2062f2ba by Gerd Hoffmann >>> <kra...@redhat.com> >> >> This concerns me, given the incompatible license of seabios. >> >> Your "Contributed-under: TianoCore Contribution Agreement 1.0" should >> be an indication from you that the files are usable under OvmfPkg's >> BSD license. (See OvmfPkg/Contributions.txt). >> >> Of particular concern is OvmfPkg/AcpiTables/Ssdt.asl, >> which lists a license of "GNU LGPL, version 2.1 or later" >> OvmfPkg requires BSD licensed contributions. (See OvmfPkg/License.txt) > > Right, I have checked the contributor agreement before, an we've > discussed this with Paolo because I was worried as well. > > The copyright holder of that SeaBIOS commit is Red Hat (via Gerd), thus > I can re-contribute it (on behalf or Red Hat) under a different open > source license.
Yes, that sounds correct, if Red Hat is the copyright holder. > I didn't spend much time on customizing the license block, because I > expected changes anyway (this being an RFC series), and I'd like it to > be reviewed same as the code. I see. The license issue was concerning enough that I wanted to straighten that out before proceeding. I'll review the series... > Do you want me to copy the full text from "OvmfPkg/License.txt" to the > top of "OvmfPkg/AcpiTables/Ssdt.asl", or would you prefer a reference to > it (that is, "2-clause BSD License", maybe with a pointer to > "OvmfPkg/License.txt")? For consistency I think you should copy the file header style of Dsdt.asl. Thanks, -Jordan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
