Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> (Assuming it works for Laszlo.)
-Jordan On Wed, Oct 3, 2012 at 5:22 PM, Kinney, Michael D <michael.d.kin...@intel.com> wrote: > Jordan, > > Here is a patch that by default keeps the current 1MB FD sizes. If > FD_SIZE_2MB is defined, then 2MB FD sizes will be used. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney <michael.d.kin...@intel.com> > > Mike > > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, October 03, 2012 4:14 PM > To: Justen, Jordan L; Kinney, Michael D > Cc: Laszlo Ersek; edk2-devel@lists.sourceforge.net > Subject: RE: [edk2] [PATCH] OvmfPkg X64 DSC files strip exception tables when > SOURCE_DEBUG_ENABLE is set > > Jordan, > > I prefer a define to enable 2MB images. > > I will prepare a patch that defaults to the current 1MB image and adds an > optional define to enable a 2MB image. > > Mike > > -----Original Message----- > From: Justen, Jordan L > Sent: Wednesday, October 03, 2012 3:44 PM > To: Kinney, Michael D > Cc: Laszlo Ersek; edk2-devel@lists.sourceforge.net > Subject: RE: [edk2] [PATCH] OvmfPkg X64 DSC files strip exception tables when > SOURCE_DEBUG_ENABLE is set > > On Wed, 2012-10-03 at 15:11 -0700, Kinney, Michael D wrote: >> This patch changes the FD size from 1MB to 2MB should resolve >> the build issue you saw and QEMU seems to support 2MB images. > > Is it really time to make 2MB the default? Or, should we > somehow build larger image for the exceptional cases? > > (Maybe a BUILD_2MB_IMAGE flag...) > > -Jordan > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Wednesday, October 03, 2012 2:02 PM >> To: Laszlo Ersek >> Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Kinney, Michael D >> Subject: RE: [edk2] [PATCH] OvmfPkg X64 DSC files strip exception tables >> when SOURCE_DEBUG_ENABLE is set >> >> Laszlo, >> >> I would like to be able to set both SECURE_BOOT_ENABLE and >> SOURCE_DEBUG_ENABLE. I will investigate further. >> >> Mike >> >> -----Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, October 03, 2012 1:58 PM >> To: Kinney, Michael D >> Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L >> Subject: Re: [edk2] [PATCH] OvmfPkg X64 DSC files strip exception tables >> when SOURCE_DEBUG_ENABLE is set >> >> On 10/03/12 21:32, Kinney, Michael D wrote: >> > The exception table information in X64 PE/COFF images is being stripped >> > by default in the OvmfPkg. >> > >> > This patch preserves this information when SOURCE_DEBUG_ENABLE is set. >> >> Reviewed-by: Laszlo Ersek >> >> ----o---- >> >> Independently / tangentially, when I build OvmfPkg at svn rev 13778 >> (simple "build" command, gcc-4.4.6, X64), I get >> >> FVMAIN_COMPACT [78%Full] 942080 total, 740608 used, 201472 free >> SECFV [66%Full] 106496 total, 70696 used, 35800 free >> >> With -D SECURE_BOOT_ENABLE: >> >> Generating FVMAIN_COMPACT FV >> ######Return Value = 2 >> GenFv: ERROR 3000: Invalid >> the required fv image size 0xe7188 exceeds the set fv image size >> 0xe6000 >> >> Normally I would edit OvmfPkg/OvmfPkgX64.fdf, increase the size of >> FVMAIN_COMPACT and decrease SECFV's size accordingly. >> >> However, with this patch applied and -D SOURCE_DEBUG_ENABLE (no other >> flags): >> >> FVMAIN_COMPACT [78%Full] 942080 total, 743168 used, 198912 free >> SECFV [98%Full] 106496 total, 105032 used, 1464 free >> >> Which means that SOURCE_DEBUG_ENABLE fills SECFV almost completely. >> Therefore I cannot pass SECURE_BOOT_ENABLE in addition, because for that >> I'd need to shift room from SECFV to FVMAIN_COMPACT, and SECFV has no >> free space with SOURCE_DEBUG_ENABLE. >> >> (This gets worse when I build virtio-blk and virtio-scsi as well, >> because then FVMAIN_COMPACT needs even more space.) >> >> Can we make FD.OVMF (= the sum of FVMAIN_COMPACT and SECFV) bigger? Or >> does it make no sense to pass both SECURE_BOOT_ENABLE and >> SOURCE_DEBUG_ENABLE? >> >> Thanks, >> Laszlo > > > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
