On Wed, 2013-01-09 at 13:38 -0800, Jordan Justen wrote:
> On Wed, Jan 9, 2013 at 1:18 PM, David Woodhouse <dw...@infradead.org>
> wrote:
> > On Wed, 2013-01-09 at 13:11 -0800, Jordan Justen wrote:
> >> > +  // Clear all but the setup_header
> >> > +  SetMem (KernelSetup, 0x1f1, 0);
> 
> What about OFFSET_OF rather than 0x1f1?

It's actually defined as 0x1f1, and the struct is built to match. So I
think 0x1f1 is probably the better option.

> Can you use ZeroMem for these?

Done. Git tree with four patches (including the first one updated to use
lea/push as discussed) at
  http://git.infradead.org/users/dwmw2/edk2.git
   git://git.infradead.org/users/dwmw2/edk2.git

Note that the final patch (the EFI bootstub one) is *not* to be applied
yet. It uses flags in the kernel's setup_header which aren't there yet
in anything but my own kernel tree (users/dwmw2/efi.git).

-- 
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature

------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to