Hi Andrew, Already following your suggestion I think I've found a solution for the warning being promoted as error: src/edk2/StdLib/LibC/Containers/Queues/Fifo.c: In function ‘New_cFIFO’: src/edk2/StdLib/LibC/Containers/Queues/Fifo.c:508: error: assignment from incompatible pointer type.
In Fifo.c, the FIFO_Truncate returns a 'size_t' (the number of remaining elements in the FIFO) while in Fifo.h it is defined to return void. I couldn't find any use of FIFO_Truncate to check if it should be really void or size_t. Anyway, I changed the .h to: typedef size_t (EFIAPI *cFIFO_Truncate) (cFIFO *Self); And it seems to work. On Tue, Jan 15, 2013 at 6:10 PM, Andrew Fish <af...@apple.com> wrote: > As a general rule of thumb I would suggest the following.... > > If you get a warning, that we promote to an error, it is likely that it will > be easy to fix with a cast. The reason is a lot of the work happens with > Visual Studio but we have warning cranked way up. Both gcc and clang are > more pedantic than Visual Studio. I think Visual Studio choses to let some > things slide due to the need to support historical code. I don't even think > the Windows headers would compile at the warning == error level we have set > in the edk2 project. > > If you get a crash or arguments look bad it could be bad usage of EFIAPI. As > I pointed out since on non GCC compilers it is a no-op and misuse does not > cause compiler warnings it is a possible cause of GCC only bugs. > > It is also possible that just throwing a new compiler at the code will find > latent bugs, so you could be finding a bug that just has never manifested > itself. > > If you are having trouble getting debugging working it is probably a good > idea to ask folks on the list for help and info about your toolchain. > > Also remember the EADK (StdLib) does not currently support as many compilers > as the core edk2 code. Daryl is working on it, and I'm sure he is glad to get > help. For example see if you can fix the warning with a cast, or see if you > can find the missing or extra EFIAPI and file a bug report or post to the > list. Thanks for the help. > > Andrew Fish > > > On Jan 15, 2013, at 11:17 AM, Mauro Faccenda <facce...@gmail.com> wrote: > >> Hi Andrew, >> >> Just reporting that the GCC version doesn't seem to be the problem >> since I've got the exact same problems using Ubuntu 10.4 with GCC 4.4 >> (however I didn't try GCC 4.5). >> > > OK Thanks. > >> Cheers, >> >> On Tue, Jan 15, 2013 at 12:56 PM, Andrew Fish <af...@apple.com> wrote: >>> >>> >>> I also noticed that the StdLib readme.txt states that only GCC 4.4 and 4.5 >>> are currently supported and the bug reports in this thread seem to be >>> against GCC 4.6. So that would probably explain why there are new warnings >>> in the code base. I've not tried to compile the StdLib with the latest Xcode >>> and it is not listed as being a supported toolchain. >> >> ------------------------------------------------------------------------------ >> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS >> and more. Get SQL Server skills now (including 2012) with LearnDevNow - >> 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. >> SALE $99.99 this month only - learn more at: >> http://p.sf.net/sfu/learnmore_122512 >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > ------------------------------------------------------------------------------ > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only - learn more at: > http://p.sf.net/sfu/learnmore_122512 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
