On Apr 22, 2013, at 2:48 AM, Patrick Georgi <patr...@georgi-clan.de> wrote:
> Am 21.04.2013 21:22, schrieb Jordan Justen: >> On Sun, Apr 21, 2013 at 4:04 AM, Shalev, Tomer <tomer.sha...@intel.com> >> wrote: >>> Ø DEFINE GCC46_X64_CC_FLAGS = DEF(GCC45_X64_CC_FLAGS) >>> -Wno-unused-but-set-variable -mabi=ms >> >> This is not a bug. It indicates that some function declaration or >> prototype is not using EFIAPI properly. >> >> So, basically it points out that there is a bug somewhere else in the >> source tree. Your CC_FLAGS change would just hide that other source >> code bug. > Sounds like a worthwhile project to build tiano configurations both with > the flag disabled and enabled and checking the differences in objdump > output? > Thats not going to work. If you set -mabi=ms then all calls, that are not optimized, are going to follow the EFIABI calling convention. The other scheme defaults to the UNIX ABI and only uses EFIABI when EFIABI is in the code. The compiler is smart enough to know that anything that has EFIABI is a public interface that is getting exported to others so it can not optimize the calling conventions. For calls internal to your code the compiler can optimize away the calling convention, and even optimize away the function and inline it. So assuming the compiler is going to generate the same code is not a safe assumption to make. > (and if there's some automatic build facility: Do it for every commit > and test that things look the same) > > I think we would need a scheme where we could force the compiler to warn when EFIABI is missing. Note I'm not sure this is possible given how types work with C and the language extensions that get used for things like __attributes__. Thanks, Andrew Fish > Regards, > Patrick > > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter_______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
