Yes, your change should work.

Thanks Jaben,

Olivier

 

From: Carsey, Jaben [mailto:[email protected]] 
Sent: 07 May 2013 18:57
To: Olivier Martin
Cc: [email protected]; Harry Liebel; Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: Fixed build error 'variable set but not used'

 

Olivier,

 

For DmpStore will this work instead of your proposed change?  The reason is
that I think the STATUS_ABORTED is good to return to the caller in case a
script file is checking return values.

 

-Jaben

 

From: Olivier Martin [mailto:[email protected]] 
Sent: Tuesday, May 07, 2013 9:34 AM
To: Carsey, Jaben
Cc: [email protected]; Harry Liebel
Subject: [PATCH] ShellPkg: Fixed build error 'variable set but not used'
Importance: High

 

Dear ShellPkg maintainer,

Please find the attached patch that fixes the ShellPkg build for the GCC
toolchain.

GCC raises a warning when a variable is initialized but not used; but
warnings are treated as error (to ensure quality in our code).

Regards,

Olivier
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to