I am not convinced by this patch. The use case you gave is the automated build system. Nothing prevent you to do a move the folder around after building it. Instead of changing all the DSC files of EDK2, I would prefer to see a patch that changes the 'build' command to allow to overwrite the Build directory defined in the DSC file.
> -----Original Message----- > From: Ryan Harkin [mailto:[email protected]] > Sent: 21 June 2013 09:05 > To: [email protected]; [email protected]; > [email protected]; [email protected]; Olivier Martin > Subject: [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for > EDK2_OUT_DIR build parameter > > Add support to the build config to allow the user to specify a custom > output > directory to the build. > > This is particularly useful for automated build systems. > > Eg. > build -a ARM -p ArmPlatformPkg/ArmVExpressPkg/ArmVExpress- > CTA9x4.dsc > -t ARMLINUXGCC \ > -D EDK2_ARMVE_STANDALONE=1 \ > -D EDK2_OUT_DIR=Build/vea9 > > Signed-off-by: Ryan Harkin <[email protected]> > --- > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 4 ++++ > .../ArmVExpressPkg/ArmVExpress-CTA9x4.dsc | 4 ++-- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc | 4 ++++ > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 4 ++++ > .../ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc | 4 ++++ > 5 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > index 17aba33..c8b637a 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -21,7 +21,11 @@ > PLATFORM_GUID = 0b511920-978d-4b34-acc0- > 3d9f8e6f9d81 > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > +!ifdef $(EDK2_OUT_DIR) > + OUTPUT_DIRECTORY = $(EDK2_OUT_DIR) > +!else > OUTPUT_DIRECTORY = Build/ArmVExpress-CTA15-A7 > +!endif > SUPPORTED_ARCHITECTURES = ARM > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > index 3f9654f..b4040c2 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > @@ -21,8 +21,8 @@ > PLATFORM_GUID = eb2bd5ff-2379-4a06-9c12- > db905cdee9ea > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > -!ifdef $(EDK2_ARMVE_STANDALONE) > - OUTPUT_DIRECTORY = Build/ArmVExpress-CTA9x4-Standalone > +!ifdef $(EDK2_OUT_DIR) > + OUTPUT_DIRECTORY = $(EDK2_OUT_DIR) > !else > OUTPUT_DIRECTORY = Build/ArmVExpress-CTA9x4 > !endif > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > index 548eee5..16271b0 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15.dsc > @@ -21,7 +21,11 @@ > PLATFORM_GUID = 1665b5b1-529d-4ba1-bd51- > c3c9b29a2274 > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > +!ifdef $(EDK2_OUT_DIR) > + OUTPUT_DIRECTORY = $(EDK2_OUT_DIR) > +!else > OUTPUT_DIRECTORY = Build/ArmVExpress-RTSM-A15 > +!endif > SUPPORTED_ARCHITECTURES = ARM > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM- > A15_MPCore.dsc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM- > A15_MPCore.dsc > index 0001f8a..c0940ae 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc > @@ -21,7 +21,11 @@ > PLATFORM_GUID = 3a91a0f8-3af4-409d-a71d- > a199dc134357 > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > +!ifdef $(EDK2_OUT_DIR) > + OUTPUT_DIRECTORY = $(EDK2_OUT_DIR) > +!else > OUTPUT_DIRECTORY = Build/ArmVExpress-RTSM-A15_MPCore > +!endif > SUPPORTED_ARCHITECTURES = ARM > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > index 4315179..bdc2697 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-A9x4.dsc > @@ -21,7 +21,11 @@ > PLATFORM_GUID = e46039e0-5bb3-11e0-a9d6- > 0002a5d5c51b > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > +!ifdef $(EDK2_OUT_DIR) > + OUTPUT_DIRECTORY = $(EDK2_OUT_DIR) > +!else > OUTPUT_DIRECTORY = Build/ArmVExpress-RTSM-A9x4 > +!endif > SUPPORTED_ARCHITECTURES = ARM > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > -- > 1.7.9.5 > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
