2013/6/24 Laszlo Ersek <ler...@redhat.com>:
> On 06/24/13 15:12, Laszlo Ersek wrote:
>
>> On the other hand, I think we should implement this more simply. What do
>> you think of the attached patch?
>
> ... In any case, your patch fixes a very annoying bug. If Jordan prefers
> your patch over my suggestion (or, of course, either of you points out a
> bug in my suggestion), then I'm happy to give my R-b:
>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
>
>
> I just think that we should fix the problem more directly, not unlike
> the following pattern:
>
> int
> function(type1 param1, ...)
> {
> static bool initialized;
>
> if (!initialized) {
> /* set up stuff at first call */
> initialized = true;
> }
>
> /* do stuff needed for each call */
> return 0;
> }
Ok. I can prepare a v2 patch for that if it's necessary ..
I see you and Justin were talking about this and it seemed to me that
there could have some other alternatives, like solely rely on newer
qemu feature or fixing in more proper place
(PlatformBdsRestoreNvVarsFromHardDisk), let me know anytime if you
think I should carry on it. I can work on it (v2 patch) right away. :)
Thanks.
Michael
>
>
> Thanks,
> Laszlo
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
