Liming,
No, I do not verify this in GCC tool chain. Please help to test it.
Thanks for your help!
-Mars
From: Gao, Liming [mailto:[email protected]]
Sent: Thursday, September 05, 2013 10:47 AM
To: [email protected]
Subject: Re: [edk2] [PATCH] EfiCreateEventReadyToBootEx and
EfiCreateEventLegacyBootEx
Mars:
The patch is good. Reviewed-by: Liming Gao
<[email protected]<mailto:[email protected]>>
Besides, have you verified this patch in GCC tool chain? If yes, I will help
you commit it.
Thanks
Liming
From: Mars Lin [mailto:[email protected]]
Sent: Thursday, September 05, 2013 10:07 AM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] [PATCH] EfiCreateEventReadyToBootEx and
EfiCreateEventLegacyBootEx
Dear MdePkg maintainer,
According to UEFI specification section6.1 at CreateEventEx():
Prototype
typedef
EFI_STATUS
CreateEventEx (
IN UINT32 Type,
IN EFI_TPL NotifyTpl,
IN EFI_EVENT_NOTIFY NotifyFunction OPTIONAL,
IN CONST VOID *NotifyContext OPTIONAL,
IN CONST EFI_GUID *EventGroup OPTIONAL,
OUT EFI_EVENT *Event
);
If Type has EVT_NOTIFY_SIGNAL or EVT_NOTIFY_WAIT, then NotifyFunction must be
non- NULL and NotifyTpl must be a valid task priority level. Otherwise these
parameters are ignored.
Please consider attached patch which use dummy routine as NotifyFunction to
make sure those 2 APIs provided from library can create event as expected when
the caller does not feed in a NotifyFunction.
Also, typo is corrected.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Mars Lin <[email protected]<mailto:[email protected]>>
Thanks, -Mars
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
