On 09/26/13 20:49, Laszlo Ersek wrote:
>> > +
>> > +**/
>> > +STATIC
>> > +EFI_STATUS
>> > +EFIAPI
>> > +VirtioMmioInit (
>> > + IN OUT VIRTIO_MMIO_DEVICE *Device
>> > + )
>> > +{
>> > + // Set Mmio Page Size
>> > +
>> > + UINT8 NextDevStat;
>> > + UINT32 MagicValue;
>> > + UINT32 Version;
>> > +
>> > + //
>> > + // Execute virtio-0.9.5, 2.2.1 Device Initialization Sequence.
>> > + //
>> > + NextDevStat = 0; // step 1 -- reset device
>> > + VIRTIO_CFG_WRITE (Device, VIRTIO_MMIO_OFFSET_STATUS, NextDevStat);
> I agree that within this protocol implementation, we can ignore the
> retval check. I tried to follow what MmioWrite32() does -- it has a
> bunch of platfom-dependent implementations, but the value it is the
> value it takes as input; hence it should always succeed.
I meant
the value it *returns* is the value it takes as input
Sorry!
Laszlo
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
