On 10/16/13 19:29, Olivier Martin wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Olivier Martin <olivier.mar...@arm.com>
> ---
> .../ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c | 26 ++++++++++++++++
> .../ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf | 32
> ++++++++++++++++++++
> .../ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.dsc | 5 +++
> .../ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf | 7 ++++-
> 4 files changed, 69 insertions(+), 1 deletions(-)
> create mode 100644 ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c
> create mode 100644 ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
>
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c
> b/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c
> new file mode 100644
> index 0000000..5242989
> --- /dev/null
> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c
> @@ -0,0 +1,26 @@
> +/** @file
> +
> + Copyright (c) 2013, ARM Ltd. All rights reserved.<BR>
> +
> + This program and the accompanying materials
> + are licensed and made available under the terms and conditions of the BSD
> License
> + which accompanies this distribution. The full text of the license may be
> found at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.
> +
> +**/
> +
> +#include <Library/UefiLib.h>
> +
> +EFI_STATUS
> +EFIAPI
> +ArmFvpInitialise (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> +
> + return EFI_SUCCESS;
> +}
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
> b/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
> new file mode 100644
> index 0000000..95e6fba
> --- /dev/null
> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
> @@ -0,0 +1,32 @@
> +#/** @file
> +#
> +# Copyright (c) 2013, ARM Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD
> License
> +# which accompanies this distribution. The full text of the license may be
> found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.
> +#
> +#**/
> +
> +[Defines]
> + INF_VERSION = 0x00010006
> + BASE_NAME = ArmFvpDxe
> + FILE_GUID = fe61bb5f-1b67-4c24-b346-73db42e873e5
> + MODULE_TYPE = UEFI_DRIVER
> + VERSION_STRING = 1.0
> + ENTRY_POINT = ArmFvpInitialise
> +
> +[Sources.common]
> + ArmFvpDxe.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> + ArmPlatformPkg/ArmPlatformPkg.dec
> +
> +[LibraryClasses]
> + UefiDriverEntryPoint
> + UefiBootServicesTableLib
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.dsc
> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.dsc
> index 9c4d0bd..f01f42a 100644
> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.dsc
> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.dsc
> @@ -255,6 +255,11 @@
> ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
>
> #
> + # Platform Driver
> + #
> + ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
> +
> + #
> # FAT filesystem + GPT/MBR partitioning
> #
> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf
> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf
> index c732442..4210e6c 100644
> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf
> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf
> @@ -163,7 +163,12 @@ READ_LOCK_STATUS = TRUE
> #
> INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
> INF ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
> -
> +
> + #
> + # Platform Driver
> + #
> + INF ArmPlatformPkg/ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf
> +
> #
> # UEFI application (Shell Embedded Boot Loader)
> #
>
Seems sane from the distance that I'm looking at it from...
A one-liner commit message would be nice ("this is just a skeleton,
we're going to add the guts in the next patch" or some such), but it's
your call.
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
If you add the commit msg in v5 but don't change the patch, you can keep
my R-b.
Also, just to stress the x86_64-specific nature of my testing (which I
mentioned in my Tested-by email posted for the entire series):
Not-tested-by: Laszlo Ersek <ler...@redhat.com>
Thanks
Laszlo
------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
