On 2014-01-30 06:36:08, Wei Liu wrote: > On Wed, Jan 29, 2014 at 02:45:55PM -0800, Jordan Justen wrote: > > This is a subset of the current ovmf-s3 branch at: > > https://github.com/jljusten/edk2.git > > > > The goal is to bring the Xen boot path back together with > > the QEMU boot path as much as possible. This will allow > > the rest of S3 support to not break Xen normal boots, and > > hopefully will allow Xen to support S3 as well. > > > > The only nit I can see is that you have > > DEBUG ((EFI_D_INFO, "Using memory map provided by Xen\n")); > > in both patch 3 and patch 8. It leads to print out that line twice.
Ah, good catch. I'll fix that. > Other than that everything looks good. > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Thanks! ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel