Get your point. It makes sense. Thanks for explanation. I found you put the pcd definition at [PcdsFixedAtBuild] section. I would suggest you put it to [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] section.
Reviewed-by: Tian, Feng <[email protected]> -----Original Message----- From: Olivier Martin [mailto:[email protected]] Sent: Wednesday, February 12, 2014 09:03 To: Tian, Feng; [email protected] Subject: RE: [edk2] [PATCH] MdeModulePkg/DiskIo: Introduced 'PcdDiskIoDataBufferBlockNum' Hi Feng, we need this change to run UEFI on a platform that has a limited amount of system memory. Otherwise, we must change the source files to be able to run UEFI. Thanks, Olivier ________________________________________ From: Tian, Feng [[email protected]] Sent: 12 February 2014 00:59 To: Olivier Martin; [email protected] Cc: Tian, Feng Subject: RE: [edk2] [PATCH] MdeModulePkg/DiskIo: Introduced 'PcdDiskIoDataBufferBlockNum' Hi, Olivier You need tell me why you need expose this parameter? What's your intention & use case? Thanks Feng From: Olivier Martin [mailto:[email protected]] Sent: Tuesday, February 11, 2014 22:50 To: [email protected]; Tian, Feng Subject: RE: [edk2] [PATCH] MdeModulePkg/DiskIo: Introduced 'PcdDiskIoDataBufferBlockNum' Thanks Mike for the feedback, I attached the new version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <[email protected]<mailto:[email protected]>> From: Kinney, Michael D [mailto:[email protected]] Sent: 10 February 2014 21:22 To: [email protected]<mailto:[email protected]>; Tian, Feng Subject: Re: [edk2] [PATCH] MdeModulePkg/DiskIo: Introduced 'PcdDiskIoDataBufferBlockNum' Olivier, It would be better to remove the #define all together and use PcdGet32() instead of the define name. This will allow the PCD to be more flexible and support both FixedAtBuild and PatchableInModule types. Thanks, Mike From: Olivier Martin [mailto:[email protected]] Sent: Monday, February 10, 2014 9:18 AM To: Tian, Feng Cc: [email protected]<mailto:[email protected]> Subject: [edk2] [PATCH] MdeModulePkg/DiskIo: Introduced 'PcdDiskIoDataBufferBlockNum' Dear MdeModulePkg maintainer, Please find the attached patch that introduced 'PcdDiskIoDataBufferBlockNum'. PcdDiskIoDataBufferBlockNum replaced the hardcoded value into the Disk I/O driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <[email protected]<mailto:[email protected]>> Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
