Looks good.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com>

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Monday, February 24, 2014 11:18 AM
To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Cc: Brendan Jackman
Subject: RE: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in 
GetAlias and SetAlias
Importance: High

Oops forgot the attachment - thanks Jaben :)

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 24 February 2014 19:09
To: Carsey, Jaben
Cc: Brendan Jackman; 
edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in 
GetAlias and SetAlias

Dear ShellPkg maintainer,

Please find the attached patch that makes the alias case insensitive.

ShellCommandIsOnAliasList is case insensitive, but GetAlias and SetAlias use 
the UEFI variable services, which are case sensitive.

Force alias names to lowercase to get around this.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brendan Jackman 
<brendan.jack...@arm.com<mailto:brendan.jack...@arm.com>>
Reviewed-By: Olivier Martin 
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>>

Best Regards,
Olivier
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to