Dear sirs,
As I found my UEFI BIOS (American Megatrend) does’n support
UnicodeCollationProtocol but supports UnicodeCollation2Protocol so with this
chage ShellPkg works for me.
There is also one of my realization of ASSERT replacement because at RELEASE
build the function will not be called.
————————
--- Shell-old.c 2014-03-25 22:27:51.000000000 +0400
+++ Shell.c 2014-03-25 22:35:05.000000000 +0400
@@ -815,10 +815,18 @@ ProcessCommandLine(
// like a shell option (which is assumed to be `file-name`).
Status = gBS->LocateProtocol (
+ &gEfiUnicodeCollation2ProtocolGuid,
+ NULL,
+ (VOID **) &UnicodeCollation
+ );
+ if (EFI_ERROR(Status)) {
+ Status = gBS->LocateProtocol (
&gEfiUnicodeCollationProtocolGuid,
NULL,
(VOID **) &UnicodeCollation
);
+
+ }
if (EFI_ERROR (Status)) {
return Status;
}
@@ -2574,7 +2582,10 @@ RunScriptFileHandle (
CHAR16 LeString[50];
SHELL_STATUS CalleeExitStatus;
- ASSERT(!ShellCommandGetScriptExit());
+// ASSERT(!ShellCommandGetScriptExit());
+ if (ShellCommandGetScriptExit()) {
+ return (EFI_NOT_STARTED);
+ }
CalleeExitStatus = SHELL_SUCCESS;
————————————
It also assumed the gEfiUnicodeCollation2ProtocolGuid must be included into
Shell.inf file.
Review, please, this patch.
ShellPkg: Support for UnicodeCollation2Protocol
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sergey Isakov <[email protected]>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
