That patch looks good to me.
Reviewed-by: Jaben Carsey <[email protected]>

Brendan or Olivier,  this is the same part of the shell that you made a recent 
change to.  Can one of you please review this patch?

I will wait to commit this patch until at least Friday the 4th of April to give 
you time to review it.

-Jaben

From: Phillips, Chris J (BCS CFE) [mailto:[email protected]]
Sent: Tuesday, April 01, 2014 3:07 PM
To: Carsey, Jaben; [email protected]
Subject: ShellPkg: Fix command-line parsing to start with Argv[0] when 
comparing passed-in options
Importance: High


Please review the attached patch file.



This update resolves an issue where a UEFI Shell boot option is created with 
OptionalData that contains UEFI Shell spec defined command-line options 
starting in Argv[0].  The prior code change skipped processing the first 
passed-in option.



Thanks,

Chris







ShellPkg: Fix command-line parsing to start with Argv[0] when comparing 
passed-in options



Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Chris Phillips <[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to