Gabriel -- I think that Yi's point is that this structure method of finding the tables is optional and is deprecated. On UEFI system, the tables are found using the EFI System Configuration table, searching it for the GUID he mentioned. Many X86 systems still support both means of finding the tables, but ARM systems only support the UEFI method.
Tim -----Original Message----- From: Gabriel L. Somlo [mailto:gso...@gmail.com] Sent: Wednesday, May 14, 2014 9:48 AM To: Yi Li Cc: edk2-devel@lists.sourceforge.net; pbonz...@redhat.com; liyi 00215672 Subject: Re: [edk2] edk2-devel Digest, Vol 53, Issue 25 [OvmfPkg/SMBIOS: Add QEMU-2.1 support] On Wed, May 14, 2014 at 08:17:30AM +0800, Yi Li wrote: > Hi Gabrie, > > Why do you use legacy method to find SMBIOS entry(like "_SM_") > only in GetQemuSmbiosTables()? > > there is no "_SM_" support on ARM platform, but > SMBIOS_TABLE_GUID is usable, could you consider to add > SMBIOS_TABLE_GUID > > support in that function? Hello Yi, I'm using this as reference: http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.8.0.pdf Check out Section 5.2.1 on page 21 (Entry Point). It's not so much a method to find the entry that I'm using -- it's more that I'm doing additional checks to make extra sure QEMU provided a valid set of (entry point + tables blob). Then (similarly to how Xen does it) I ignore the entry point completely and clone each structure in the tables blob using InstallAllStructures(). Per the spec, the entry point is expected to contain the strings "_SM_" and "_DMI_" in the appropriate fields. So if they're not where they're expected to be, then we're in trouble :) Hope this clears it up... Thanks, --Gabriel ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
