That looks correct to me.  Tapan, please verify on your end.

Thanks,
-Erik

Reviewed-by: Erik Bjorge <[email protected]>

From: Carsey, Jaben
Sent: Thursday, May 22, 2014 2:05 PM
To: Bjorge, Erik C; Shah, Tapan ([email protected])
Cc: [email protected]; Carsey, Jaben
Subject: RE: ShellPkg: replace unrecognized Environment Variables

You're right.  I think this is the correct behavior.  Can you double check.

From: Bjorge, Erik C
Sent: Thursday, May 22, 2014 2:01 PM
To: Carsey, Jaben; Shah, Tapan ([email protected]<mailto:[email protected]>)
Cc: [email protected]<mailto:[email protected]>
Subject: RE: ShellPkg: replace unrecognized Environment Variables
Importance: High

It looks like this may have a bug if two environment variable exist in the 
string.  Jaben, can you double check where you restart your string processing?

Thanks,
-Erik

From: Carsey, Jaben
Sent: Thursday, May 22, 2014 1:49 PM
To: Bjorge, Erik C; Shah, Tapan ([email protected]<mailto:[email protected]>)
Cc: [email protected]<mailto:[email protected]>; 
Carsey, Jaben
Subject: ShellPkg: replace unrecognized Environment Variables

Erik or Tapan,

Can you review?


ShellPkg: replace unrecognized Environment Variables with empty quotes so 
commands or applications know something existed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to