You misunderstands this code. The pseudo code is: 1) Check if D2H is received; 2) If yes, then return ERROR;
Thanks Feng -----Original Message----- From: Reza Jelveh [mailto:[email protected]] Sent: Monday, June 23, 2014 09:18 To: Tian, Feng Cc: [email protected]; Alexander Graf Subject: Re: [edk2] OvmfPkg: problems getting ahci mode working with satacontroller On 23/06/14 00:26, Tian, Feng wrote: > Hi, Reza > > According to SATA2.6 section 11.7 PIO data-in command protocol, the device > will send D2H to show there is an error happened. So it should return device > error here. Tiang, That can't be right. First of all the check is basically saying if (noerror) return error; Assuming we should really return all errors as device error at this point and we invert the check. It will cause a read timeout every time a read happens, which means ovmf becomes mega slow doing nothing. maybe you want the the whole thing to be EFI_ERROR(Status) ? return EFI_DEVICE_ERROR : break; but then I'm still not sure the rest of the code is correct. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
