Here is the updated patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen <eug...@hp.com<mailto:eug...@hp.com>>
The changes are: 1. Add RVCT ARM build target 2. Add suppression of warnings to get openssl building (1295,550,1293,111,68,177,223,144,513,188) 3. Remove architectures that RVCT cannot build for (IA32, X64, and IPF) 4. Add the -DOPENSSL_NO_MD2 flag to prevent link errors from MD2 references; the comments in the .inf assumes that this flag exists but it wasn't actually set Thanks, Eugene From: Long, Qin [mailto:qin.l...@intel.com] Sent: Tuesday, August 05, 2014 9:05 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM Copy that. Thanks, Eugene. Best Regards & Thanks, LONG, Qin From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Tuesday, August 05, 2014 11:29 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM I agree with Olivier's comments, it's good to document this stuff. Also the updated patch will remove the IA32, X64, and IPF rules for RVCT since this toolchain does not support these architectures. I'm working through other merge out issues at the moment so when I get past these I will provide the updated patch. Eugene From: Long, Qin [mailto:qin.l...@intel.com] Sent: Monday, August 04, 2014 8:02 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM Thanks, Martin & Eugene. Eugene, would you like to update your patch to add this kind of correlation description about the warning number & messages as Martin's comments? Best Regards & Thanks, LONG, Qin From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Monday, August 04, 2014 10:29 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM If I was the CryptoPkg maintainer I would probably request to add the correlation between the warning numbers and their associated warning messages. I did that for SctPkg: # 167: "argument of type <type1> is incompatible with parameter of type # <type2>" # (caused here by passing typed pointers to functions that take "void *" or "void **") # 1295: "provide arguments" (i.e. `UINTN Function ()` should be `UINTN Function (VOID)`) # 188: "enumerated type mixed with another type" # (i.e. passing an integer as an enum without a cast) # 550: "variable <var> was set but never used" # 1: "last line of file ends without a newline" # 68: "integer conversion resulted in a change of sign" ("if (Status == -1)") # 111: "statement is unreachable" (invariably "break;" after "return X;" in case statement) # 177: "function <static function> was declared but never referenced" RVCT:*_*_ARM_CC_FLAGS = --diag_remark=167 --diag_suppress=167,1295,188,550,1,68,111,177 That would help the maintainer to remove a warning id when it should have been fixed into OpenSslLib source code. Nothing to do with this patch, but it's interesting to see RVCT (ARM RealView Toolchain) supporting IA32/X64/IPF architectures. From: Cohen, Eugene [mailto:eug...@hp.com] Sent: 04 August 2014 15:09 To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM The ARM toolchain definitions are configured to treat warnings as errors. The openssl code has numerous warnings so this patch tells the ARM RVCT compiler to ignore those warnings. This patch also fixes an issue where the openssl compiler flags were not being provided for the RVCT toolchain. I'm not sure if we have a channel back to openssl developers but it would be best if the code could get cleaned up so the warnings could be eliminated entirely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen <eug...@hp.com<mailto:eug...@hp.com>>
get-openssl-0.9.8az-building-on-RVCT.patch
Description: get-openssl-0.9.8az-building-on-RVCT.patch
------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
