Reviewed-by: Jaben Carsey <jaben.car...@intel.com> From: Qiu, Shumin Sent: Tuesday, August 12, 2014 6:29 PM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH]ShellPkg: Fix code style and build failure Importance: High
Hi Jaben, Can you help to review this patch. ShellPkg: Fix code style and build failure 1. File has invalid Non-ACSII char. 2. No initialization of a variable as part of its declaration. 3. Close braces for function body must be in the first column. 4. Inconsistent parameter in function comments. 5. The first line of text in a comment block should be a brief description of the element being documented and the brief description must end with a period. 6. For function 'ShellCommandDynamicCommandExists' in UefiShellCommandLib.c return type is conversed from 'int' to 'boolean'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <shumin....@intel.com<mailto:shumin....@intel.com>> Thanks Shumin
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
