Scott, You are right. The additional defines in arith.h (other than the "Long" macro for GCC) are not used by the gdtoa library. They reflect internal assumptions of the library and, as such, are not really necessary for public consumption.
Daryl McDaniel "It is the mark of an educated mind to be able to entertain a thought without accepting it." - Aristotle -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Monday, August 18, 2014 9:21 PM To: [email protected] Subject: Re: [edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h Mcdaniel, Daryl [mailto:[email protected]] wrote: ]Please review the attached changes. ] ]StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h: Use programmatically ]generated arith.h files for greater compatibility with the gdtoa library in ]StdLib. ] ]Contributed-under: TianoCore Contribution Agreement 1.0 ]Signed-off-by: Daryl McDaniel <[email protected]> ]Reviewed-by: ] ]Thank You, ]Daryl McDaniel Hello Daryl, In what way does this change provide greater compatibility with the gdtoa library? The gdtoa library is documented as for internal use by stdlib. Yet stdlib doesn't use the new defines added by this patch. Thanks, Scott ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
