I will merge the UNI in, not replace it.

I agree that I seemed to have lost something in this patch.  I will fix it and 
resend it.

From: Phillips, Chris J (Plano, TX) [mailto:[email protected]]
Sent: Thursday, August 21, 2014 12:27 PM
To: Bjorge, Erik C; Carsey, Jaben
Cc: [email protected]
Subject: RE: ShellPkg: Add cross file system moving to MV command
Importance: High

Jaben,

Looks like the .uni file needs some of the recent updates.

I will try to test it today, but I don't see PostDelete ever getting set to 
TRUE.
I also don't see CreateDirectory() getting called.  Is it really needed?

Thanks,
Chris

From: Bjorge, Erik C [mailto:[email protected]]
Sent: Thursday, August 21, 2014 12:39 PM
To: Carsey, Jaben; Phillips, Chris J (Plano, TX)
Cc: [email protected]<mailto:[email protected]>
Subject: RE: ShellPkg: Add cross file system moving to MV command

Reviewed-by: Erik Bjorge 
<[email protected]<mailto:[email protected]>>

From: Carsey, Jaben
Sent: Thursday, August 21, 2014 10:13 AM
To: Bjorge, Erik C; Phillips, Chris J (BCS CFE) 
([email protected]<mailto:[email protected]>)
Cc: [email protected]<mailto:[email protected]>; 
Carsey, Jaben
Subject: ShellPkg: Add cross file system moving to MV command

Erik or Chris,

Can you review this?

The commit will also include removing this no longer used line form the UNI 
file (file attached for the very curious):
#string STR_MV_INV_FS             #language en-US "%EError. %NCannot move 
between file systems.\r\n"

ShellPkg: Add cross file system moving to MV command


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to