Samer,

Can you please provide the details on how to reproduce an incorrect stack 
alignment.

It has been a long time since we have worked on this code, and I recall 
reviewing the stack alignment carefully at that time.

It is possible that the code that called an EBC function has misaligned the 
stack.  It is also possible that use of a newer/different compiler/assemble 
could be causing some issues.

Thanks,

Mike

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Monday, August 25, 2014 9:22 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg: Fix EBC DXE issue with x64 function call 
alignment

Dear MdeModulePkg maintainers,

Please find the attached patch to fix a stack alignment in EBC DXE interpreter 
for X64 native calls:


Fix EBC X64 native call to be 16-byte aligned. From MSDN x64 Software 
Conventions:

"The stack will always be maintained 16-byte aligned,

except within the prolog (for example, after the return address is pushed),

and except where indicated in Function Types for a certain class of frame 
functions."


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud el...@hp.com<mailto:el...@hp.com>



Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers

el...@hp.com<mailto:el...@hp.com>
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>

[Description: Description: C:\Users\elhajmah\HpLogo.png]

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to