On Mon, Aug 25, 2014 at 8:40 AM, Carsey, Jaben <[email protected]> wrote: > Reviewed-by: Jaben Carsey <[email protected]>
Tested-by: Jordan Justen <[email protected]> committed in r15889 > From: Qiu, Shumin > Sent: Sunday, August 24, 2014 9:33 PM > To: Carsey, Jaben > Cc: '[email protected]' > Subject: [edk2][Patch][ShellPkg]Fix invalid character in ShellPkg Was this intended to be the first line of your commit message? If so, I think "[PATCH] ShellPkg: Fix invalid character" Would have better followed the preferred format: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format (Usually, items in [] are not considered part of the commit message.) -Jordan ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
