On Tue, Aug 26, 2014 at 10:38 PM, Gao, Liming <liming....@intel.com> wrote: > Jordan: > After UPT clean up, those files can still edit easily. UPT tool just > changes section Order and Alignment. The source package can > still directly be compared. So, daily work is no change.
No, they cannot be directly compared. Just look at the size of your patch. It will not be possible to compare a tree before and after this change. It is not even really possible to review the patch. Source control history is being sacrificed for UPT. Isn't this exactly the kind of thing that people hate? A tree wide, search-replace that makes diff'ing impossible? I still think it is strange that UPT can't help the user to diff things, rather than munging all these source files in the tree. And, this is not just a one time thing. It'll happen every release... -Jordan > -----Original Message----- > From: Jordan Justen [mailto:jljus...@gmail.com] > Sent: Wednesday, August 27, 2014 12:16 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [Patch 2/2] [MdePkg] INF/DEC file updates to EDK II > packages > > On Tue, Aug 26, 2014 at 7:17 AM, Gao, Liming <liming....@intel.com> wrote: >> Jordan: >> UPT clean up main purpose has been mentioned in Mike email. "This >> allows UDP packages installed by UPT to be compared against EDK II >> trunk/branches using standard diff utilities." > > I thought we moved away from xml files to have files that a developer could > edit easily with a text editor. But, now we can't just edit these files > unless we do things just right for some tool. (That I personally don't plan > to ever use.) > > So, you will sacrifice being able to diff the actual files in source control > so you can diff the files after running them through some tool? > >> For new added section, they may not follow UPT order. >> We can clean up them together on next major release. > > Great. So, this will just keep happening. Woohoo. > > -Jordan > >> -----Original Message----- >> From: Jordan Justen [mailto:jljus...@gmail.com] >> Sent: Tuesday, August 26, 2014 2:28 PM >> To: edk2-devel@lists.sourceforge.net >> Subject: Re: [edk2] [Patch 2/2] [MdePkg] INF/DEC file updates to EDK >> II packages >> >> On Mon, Aug 25, 2014 at 7:01 PM, Gao, Liming <liming....@intel.com> wrote: >>> Jordan: >>> The real requirement is that some users use UPT to install core >>> package into the different directories, such as Core\MdePkg. >>> After the installation, they want to easily compare the original >>> package and installed package. >> >> Can't the tool help to easily compare the package without the order of these >> sections being so strict? >> >>> This change is required by EDKII project major release, but not required >>> for daily development. >>> >>> The section order will not be changed unless new section are introduced >>> in INF/DEC. >> >> But what about when a developer add a new section to a .inf or .dec? >> Will there be a major EDK II cleaning every six months? >> >>> Yes. Those changes are directly output from UPT tool. And, we have test >>> to cover this tool. So, I have confidence. >> >> Okay, so it seems likely that either the tool: >> * broke the world, or >> * didn't break anything >> >> At least there shouldn't be a needle in a haystack problem. >> >>> So far, I have no branch for those change. If you request, I could >>> send zip the source INF/DEC (before UPT and after >>> UPT) to you. >> >> No thanks. I would prefer that you start using git, and post a branch with >> your changes incorporated. >> >> -Jordan >> >> ---------------------------------------------------------------------- >> -------- >> Slashdot TV. >> Video for Nerds. Stuff that matters. >> http://tv.slashdot.org/ >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel >> >> ---------------------------------------------------------------------- >> -------- >> Slashdot TV. >> Video for Nerds. Stuff that matters. >> http://tv.slashdot.org/ >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
