Hello Jaben,
A typing error in line 68 of this patch is breaking the build:
- MapListNode->MapName = AllocateZeroPool(StrSize(Name));
+ MapListNode->MapName = AllocateZeroPool(StrSize(Name), Name);
Probably intended was:
- MapListNode->MapName = AllocateZeroPool(StrSize(Name));
+ MapListNode->MapName = AllocateCopyPool(StrSize(Name), Name);
Thanks,
Scott
-----Original Message-----
From: Bjorge, Erik C [mailto:[email protected]]
Sent: Friday, August 29, 2014 04:12 PM
To: Carsey, Jaben
Cc: [email protected]
Subject: Re: [edk2] ShellPkg: Refactor string manipulation in commands (#3)
Reviewed-by: Erik Bjorge <[email protected]>
-----Original Message-----
From: Carsey, Jaben
Sent: Friday, August 29, 2014 2:05 PM
To: Bjorge, Erik C
Cc: [email protected]; Carsey, Jaben
Subject: ShellPkg: Refactor string manipulation in commands (#3)
Erik,
Can you verify please?
This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy
through some other means.
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat
through some other means.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <[email protected]>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
