Ni, Ruiyu [mailto:[email protected]] wrote:
]Reviewed-by: Ruiyu Ni <[email protected]> ] ]From: Qiu, Shumin [mailto:[email protected]] ]Sent: Tuesday, September 23, 2014 2:08 PM ]To: Carsey, Jaben ]Cc: [email protected] ]Subject: Re: [edk2] [Patch] ShellPkg: Refine code style to avoid potential NullPointer ]dereference. ] ]Update the patch to use ASSERT. ASSERT does nothing for a release build, or any other build where NDEBUG is defined, right? Also, I don't understand the problem to be fixed: Pointer 'CleanFilePathStr' returned from function 'ShellLevel2StripQuotes' may be NULL and may be dereferenced Function ShellLevel2StripQuotes() checks the return pointer it allocates and returns status EFI_OUT_OF_RESOURCES if it is null. When cp.c and mv.c call ShellLevel2StripQuotes(), both return immediately without using the returned pointer if the return status is bad. Thanks, Scott ]Thanks, ]Shumin ] ]From: Qiu, Shumin [mailto:[email protected]] ]Sent: Tuesday, September 23, 2014 11:03 AM ]To: Carsey, Jaben ]Cc: [email protected] ]Subject: [edk2] [Patch] ShellPkg: Refine code style to avoid potential NullPointer dereference. ] ]Hi Jaben, ]Could you help review the patch? Pointer 'CleanFilePathStr' returned from function ]'ShellLevel2StripQuotes' may be NULL and may be dereferenced. ] ]Contributed-under: TianoCore Contribution Agreement 1.0 ]Signed-off-by: Qiu Shumin <[email protected]> ] ]Thanks, ]Shumin ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
