On Wed, Oct 22, 2014 at 08:30:00PM +0200, Laszlo Ersek wrote: > On 10/22/14 20:09, Gabriel Somlo wrote: > > On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: > >> On 10/22/14 18:24, Gabriel Somlo wrote: > > >>> I now get this error: > >>> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/PcdLib.h:377:45: > >>> error: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared (first > >>> use in this function) > >>> #define PcdGet16(TokenName) > >>> _PCD_GET_MODE_16_##TokenName > >> > >> Did you add PcdLib under [LibraryClasses] in > >> "OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf"? > >> > >> The PcdGet16() macro should expand to a library call -- LibPcdGet16() -- > >> which would internally use the PCD protocol. This macro definition would > >> be generated by "BaseTools/Source/Python/AutoGen/GenC.py" during the build. > > > > Doing that didn't help, getting the exact same error. > > Hrmpf. I'd have to see your tree. I don't have any better guess now. > Please try to answer to Andrew with the file he mentioned, or push your > tree to somewhere public.
Thanks for pointing out that message, I missed it (no cc and I get the list in digest mode). I put up a tarball (should work around any CR-LF craziness) containing five patches at http://www.contrib.andrew.cmu.edu/~somlo/OvmfPcdQ35.tgz They should apply on top of the latest git master, and the first four build fine (including setting the PCD). The fifth is the one which gives me trouble, when I try to actually read the PCD. Sorry it's not a git repo, I've never been in a position to need a public tree for my stuff yet :) Maybe that's something I should start thinking about :) Thanks much, --Gabriel > > > Besides, PcdGet16 (PcdAcpiPmBaseAddress) in the current version of > > AcpiTimerLib.c seems to work fine with no PcdLib in AcpiTimerLib.inf, > > and now I wonder how come :) > > That PCD is under [PcdsFixedAtBuild] in "OvmfPkg/OvmfPkg.dec". IOW it > can only be a fixed PCD; the DSCs that use it have no wiggle room in > selecting the PCD's actual flavor. > > Laszlo > ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
