Reviewed-by: Erik Bjorge <[email protected]>
From: Mcdaniel, Daryl
Sent: Friday, October 24, 2014 3:50 PM
To: [email protected]; Carsey, Jaben; Bjorge, Erik C
Cc: Bruce Maynard ([email protected])
Subject: [PATCH] StdLib Console Input fix to eliminate NUL characters from the
stdin stream.
Please review the attached patches. The attached patch file covers all
modified files. I also included the full source file for daConsole.c since it
has structural as well as code changes.
StdLib: Some deployed versions of the Simple Text Input Protocol randomly
return either NUL characters or Scan Codes when just typing normal text. These
changes filter out NUL characters and make Scan Code and error handling more
robust.
StdLibPrivateInternalFiles/Include/Device/Console.h: Change UnGetKey, in the
ConInstance structure, from an EFI_INPUT_KEY structure to a CHAR16 variable.
StdLib/Include/sys/termios.h: Add CHAR_SUB and CHAR_ESC for translation of '^Z'
and the Escape Scan Code into the EOF and ESC characters, respectively.
StdLib/LibC/Uefi/Devices/Console/daConsole.c: Add da_ConRawRead() function to
simplify the read logic. Discard NUL characters from the input stream. In
Blocking mode, retry until a non-NUL character is received. In NonBlocking
mode, a NUL causes an EAGAIN error to be returned. Translate the Escape Scan
Code into an ESC character. If Scan Codes are ignored, retry if in Blocking
mode else return an EAGAIN error. UnGetKey becomes a single wide character
instead of a structure.
Change da_Poll() to use da_ConRawRead().
IIOutilities.c: BUG fix. Return the processed input character instead of the
raw character. Allows EOF propagation.
CanonRead.c: Enable EOF propagation.
IIOechoCtrl.h: Use symbols defined in termios.h instead of hard-coded constant
numbers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daryl McDaniel
<[email protected]<mailto:[email protected]>>
Reviewed-by:
Daryl McDaniel
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
