Mike,
While contemplating the NASM question I noticed that we have INF files laying
about that over specify GCC or MSFT, etc in INF files. I’m guessing in some
places it might have been intended as a comment, in other places it is lack of
understanding of what is required. Should we clean up the usage of these family
overrides in the edk2 code base?
I attached an example of a cleanup I did for the MdePkg BaseLib for IA32/X64.
>git diff MdePkg/Library/BaseLib/BaseLib.inf
diff --git a/MdePkg/Library/BaseLib/BaseLib.inf
b/MdePkg/Library/BaseLib/BaseLib.inf
index 4c77762..7f4c88f 100644
--- a/MdePkg/Library/BaseLib/BaseLib.inf
+++ b/MdePkg/Library/BaseLib/BaseLib.inf
@@ -253,30 +253,30 @@
Ia32/GccInline.c | GCC
Ia32/Thunk16.nasm | GCC
- Ia32/EnableDisableInterrupts.S | GCC
- Ia32/EnablePaging64.S | GCC
- Ia32/DisablePaging32.S | GCC
- Ia32/EnablePaging32.S | GCC
- Ia32/Mwait.S | GCC
- Ia32/Monitor.S | GCC
- Ia32/CpuIdEx.S | GCC
- Ia32/CpuId.S | GCC
- Ia32/LongJump.S | GCC
- Ia32/SetJump.S | GCC
- Ia32/SwapBytes64.S | GCC
- Ia32/DivU64x64Remainder.S | GCC
- Ia32/DivU64x32Remainder.S | GCC
- Ia32/ModU64x32.S | GCC
- Ia32/DivU64x32.S | GCC
- Ia32/MultU64x64.S | GCC
- Ia32/MultU64x32.S | GCC
- Ia32/RRotU64.S | GCC
- Ia32/LRotU64.S | GCC
- Ia32/ARShiftU64.S | GCC
- Ia32/RShiftU64.S | GCC
- Ia32/LShiftU64.S | GCC
- Ia32/EnableCache.S | GCC
- Ia32/DisableCache.S | GCC
+ Ia32/EnableDisableInterrupts.S
+ Ia32/EnablePaging64.S
+ Ia32/DisablePaging32.S
+ Ia32/EnablePaging32.S
+ Ia32/Mwait.S
+ Ia32/Monitor.S
+ Ia32/CpuIdEx.S
+ Ia32/CpuId.S
+ Ia32/LongJump.S
+ Ia32/SetJump.S
+ Ia32/SwapBytes64.S
+ Ia32/DivU64x64Remainder.S
+ Ia32/DivU64x32Remainder.S
+ Ia32/ModU64x32.S
+ Ia32/DivU64x32.S
+ Ia32/MultU64x64.S
+ Ia32/MultU64x32.S
+ Ia32/RRotU64.S
+ Ia32/LRotU64.S
+ Ia32/ARShiftU64.S
+ Ia32/RShiftU64.S
+ Ia32/LShiftU64.S
+ Ia32/EnableCache.S
+ Ia32/DisableCache.S
Ia32/DivS64x64Remainder.c
Ia32/InternalSwitchStack.c | MSFT
@@ -406,15 +406,15 @@
X86DisablePaging32.c
X64/GccInline.c | GCC
X64/Thunk16.nasm | GCC
- X64/SwitchStack.S | GCC
- X64/SetJump.S | GCC
- X64/LongJump.S | GCC
- X64/EnableDisableInterrupts.S | GCC
- X64/DisablePaging64.S | GCC
- X64/CpuId.S | GCC
- X64/CpuIdEx.S | GCC
- X64/EnableCache.S | GCC
- X64/DisableCache.S | GCC
+ X64/SwitchStack.S
+ X64/SetJump.S
+ X64/LongJump.S
+ X64/EnableDisableInterrupts.S
+ X64/DisablePaging64.S
+ X64/CpuId.S
+ X64/CpuIdEx.S
+ X64/EnableCache.S
+ X64/DisableCache.S
ChkStkGcc.c | GCC
[Sources.IPF]
Thanks,
Andrew Fish
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
