Eugene:
I have one comments on DEBUG message. It could be changed better. Other part
goods to me. Reviewed-by: Liming Gao <[email protected]>
DEBUG ((DEBUG_PAGE, "ConvertRange: %lx-%lx to %d attr %x\n", Start, RangeEnd,
NewType, NewAttributes)); ==>
If (ChangingType) {
DEBUG ((DEBUG_PAGE, "ConvertRange: %lx-%lx to type %d attr %x\n", Start,
RangeEnd, NewType));
}
If (ChangingAttributes) {
DEBUG ((DEBUG_PAGE, "ConvertRange: %lx-%lx to attr %x\n", Start, RangeEnd,
NewAttributes));
}
Thanks
Liming
From: Cohen, Eugene [mailto:[email protected]]
Sent: Saturday, November 15, 2014 4:48 AM
To: [email protected]
Cc: Felix Poludov
Subject: Re: [edk2] DXE Services: SetMemorySpaceCapabilities is missing
As discussed offline, here is a patch for review as provided by HP and then
updated by Intel (thanks!).
Please review.
Signed-off-by: Eugene Cohen <[email protected]<mailto:[email protected]>>
From: Zeng, Star [mailto:[email protected]]
Sent: Friday, October 31, 2014 5:59 AM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] DXE Services: SetMemorySpaceCapabilities is missing
Yes, it is missing, thanks for the finding, we will take effort to add it.
Thanks,
Star
From: Felix Poludov [mailto:[email protected]]
Sent: Friday, October 31, 2014 6:28 AM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] DXE Services: SetMemorySpaceCapabilities is missing
SetMemorySpaceCapabilities is a GCD extension introduced in PI 1.3.
It is not in the code base even though PiDxeCis.h states PI 1.3 compliancy.
The information contained in this message may be confidential and proprietary
to American Megatrends, Inc. This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
