Thanks Feng. Attached is the updated patch with the suggested changes. Please confirm once this is committed.
Thanks, --Samer From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, November 25, 2014 6:44 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages Minor comment: The first debug message misses a line break sign and I think you can directly use string "I2cHostI2cBusConfigurationAvailable" in format string rather than %a. Others look good to me. Reviewed-by: Feng Tian <feng.t...@intel.com<mailto:feng.t...@intel.com>> Thanks Feng From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Wednesday, November 26, 2014 06:55 To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages Dear MdeModulePkg maintainers, Please see attached patch Fixed some spelling typos in some comments. Added a couple of useful DEBUG messages Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud el...@hp.com<mailto:el...@hp.com> Thanks, Samer El-Haj-Mahmoud System Firmware Architect HP Servers el...@hp.com<mailto:el...@hp.com> T +1.281.514.5973 C +1.512.659.1523 Hewlett-Packard Company hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi> [Description: Description: C:\Users\elhajmah\HpLogo.png]
mdemodulepkg_misc.patch
Description: mdemodulepkg_misc.patch
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel