On 2014-11-28 02:28:53, Laszlo Ersek wrote: > On 11/28/14 02:27, Gao, Liming wrote: > > Laszlo: > > The patch is good. > > Reviewed-by: Liming Gao <liming....@intel.com> > > Thank you. Committed as r16454 and r16455. > > Here's some meta notes: > > (1) do we want to update Maintainers.txt in the root dir so that it has > a better "resolution" with regard to the many modules in MdePkg and > MdeModulePkg? The file doesn't explain whether UefiScsiLib's maintainer > is Liming, Feng, or Mike.
Yeah, it might be good to clarify. I think I've committed a few things with only Liming's Reviewed-by. It would be nice to have at least an Acked-by from one of the maintainers listed in Maintainers.txt. Maybe Liming should become co-maintainer for BaseTools, Mde*Pkg and IntelFramework*Pkg? :) QEMU gets more detailed, and allows paths to be specified as separately maintained. At least for the first pass, I opted to stick to the package level for maintainers. > (2) Jordan, please disable or fix the pre-commit hook. > > ERROR from SVN: > A repository hook failed: Commit blocked by pre-commit hook (exit code > 1) with output: > The commit message format is not valid: > * The line before the signature block should be empty > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > > My commit message was perfectly fine. The block-of-tags looked like this > (preceded by an empty line): > > Reported-by: Cole Robinson <crobi...@redhat.com> > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Suggested-by: Feng Tian <feng.t...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Liming Gao <liming....@intel.com> > > This should not be rejected. Hopefully fixed... -Jordan ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
