Hi Cecil,
Thanks for your comments, I will follow up it. Thank you.
Dennis
From: Sheng, Cecil (HPS SW) [mailto:[email protected]]
Sent: Thursday, December 04, 2014 8:26 AM
To: [email protected]
Cc: Liu, Yingke D
Subject: RE: [PATCH] BaseTool : Fix '/' handling in UNI files
Hi Dennis,
According to the UNI spec 1.0, L'\t' (U+0009) is not allowed in a string in a
UNI file, but allowed in the language definition part. So we cannot simply
replace L'\t' with L' '. If it's in a string, an error should be returned.
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
From: Gao, Liming [mailto:[email protected]]
Sent: Wednesday, December 3, 2014 3:42 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Dennis:
The patch is good. Reviewed-by: Liming Gao
<[email protected]<mailto:[email protected]>>
Thanks
Liming
From: Liu, Yingke D [mailto:[email protected]]
Sent: Tuesday, December 2, 2014 4:07 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Hi Cecil,
We found a regression after your patch is committed, the attached patch fix the
problem.
Contributed-Under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu
<[email protected]<mailto:[email protected]>>
Thanks,
Dennis
From: Sheng, Cecil (HPS SW) [mailto:[email protected]]
Sent: Wednesday, November 26, 2014 10:41 AM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Hi Dennis,
Thanks for your comments. I've updated the patch to handle case 1 you
mentioned. Regarding case 2, because this function only handles Unicode text
files, I think it's okay to keep it in this file. A similar function might be
needed for ANSI text files but it's not in the scope of the problem I wanted to
fix.
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
From: Liu, Yingke D [mailto:[email protected]]
Sent: Wednesday, November 26, 2014 9:35 AM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Hi Cecil,
Thanks for this patch.
Two comments about the patch:
1) Count '\"' might not be correct, for example a string with escaped
backslash: "some text\\"
2) I think the StripComments function is a common function which is better
to be defined out of the class.
Thanks,
Dennis
From: Sheng, Cecil (HPS SW) [mailto:[email protected]]
Sent: Wednesday, November 26, 2014 8:55 AM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Please review attached patch.
Corrected '/' handling in the strings of UNI files. Also the '\"' escape
sequence processing is corrected.
Contributed-Under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cecil Sheng <[email protected]<mailto:[email protected]>>
Sincerely,
Cecil Sheng
HP Servers
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
