It looks like the one function was just moved. If that is true, can you add
that to the commit log for clarity? Or maybe split that into a separate commit?
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
From: Qiu, Shumin
Sent: Thursday, December 25, 2014 4:36 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Add code to handle the split ('|') in a
double-quoted string.
Importance: High
Hi Jaben,
Please help review the attached patch.
In Shell, if we run a command containing the '|' in a double-quoted string,
Shell will treat '|' as a split instead of knowing it's in quotes and skipping
it. For example command echo "a+b | ls" will have the output: 'ls"' is not
recognized as an internal or external command, operable program, or script
file. The patch add the code to check whether the '|' is in quotes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin....@intel.com<mailto:shumin....@intel.com>>
Thanks
Shumin
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel