Reviewed-by: Jaben Carsey <[email protected]> Laszlo,
Good catch. Looks like there was a miss on the synchronization of those patches. > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Wednesday, January 14, 2015 5:02 AM > To: Carsey, Jaben; Mcdaniel, Daryl; [email protected] > Subject: [PATCH] ShellPkg: UefiShellLib: drop wrong PathLib library class > dependency > Importance: High > > SVN r16601 ("MdeModulePkg, MdePkg, NetworkPkg, OvmfPkg, > PerformancePkg, > ShellPkg: Library Migration.") incorporated ShellPkg/Library/BasePathLib into > MdePkg/Library/BaseLib. BasePathLib had been the only instance of library > class PathLib. > > Even so, SVN r16606 ("ShellPkg: allow creating of files to create required > directory path") added a PathLib dependency to > "ShellPkg/Library/UefiShellLib/UefiShellLib.inf". > > This breaks edk2 platforms that build the "new" UEFI shell from source. > Undo the wrong dependency. > > Similarly, update the <Library/PathLib.h> #include directive to > <Library/BaseLib.h> (example function prototype: PathRemoveLastItem()). > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <[email protected]> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.inf | 1 - > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.inf > b/ShellPkg/Library/UefiShellLib/UefiShellLib.inf > index da06c34..8eedfce 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.inf > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.inf > @@ -48,7 +48,6 @@ > UefiLib > HiiLib > SortLib > - PathLib > > [Protocols] > gEfiSimpleFileSystemProtocolGuid # ALWAYS_CONSUMED > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 844f17a..da4b466 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -15,7 +15,7 @@ > #include "UefiShellLib.h" > #include <ShellBase.h> > #include <Library/SortLib.h> > -#include <Library/PathLib.h> > +#include <Library/BaseLib.h> > > #define FIND_XXXXX_FILE_BUFFER_SIZE (SIZE_OF_EFI_FILE_INFO + > MAX_FILE_NAME_LEN) > > -- > 1.8.3.1 ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
