Hello Liming, It makes sense to me. Please review the new patch which remove /X in BaseTools/Conf/tools_def.template.
Thanks, Cinnamon Shia From: Gao, Liming [mailto:[email protected]] Sent: Wednesday, January 21, 2015 11:02 AM To: [email protected] Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 I think the compatibility is more important. Adding /X for IA32 arch in the default tool configuration may bring the incompatible change, because it adds new limitation. Removing /X for X64 should be compatible, because it loose the limitation. Thanks Liming From: Shia, Cinnamon [mailto:[email protected]] Sent: Friday, January 16, 2015 3:45 PM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Hello Liming, How about adding /X to for IA32 and moving the build option override (Removing /X) to the NT32 specific drivers. To stand at the engineering viewpoint, I think we should keep things simple and clear. Adding the Win32 libraries and header files to EDK2 only increase the complexity. Let me know what you think? Thanks, Cinnamon Shia From: Gao, Liming [mailto:[email protected]] Sent: Thursday, January 15, 2015 8:48 AM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Yes. Your concern is right. If you check tools_def.template, you will find IA32 arch build options has no /X, but X64 arch build options has /X. So, this risk is also in IA32 arch driver. Because most driver supports IA32 and X64, this change will not increase this risk. Thanks Liming From: Shia, Cinnamon [mailto:[email protected]] Sent: Wednesday, January 14, 2015 11:34 PM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Hello Liming, Thanks for your reply. Please correct me if I am wrong: removing /X in tools_def.template will make visual studio compiler use the "INCLUDE" and "PATH" environment variables globally. So if /X is removed in BaseTools/Conf/tools_def.template), will it increase the chance of using the visual studio header files and tools by mistake? And drivers except for NT32 specific drivers don't need them. The reason why build option override is moved from the Nt32Pkg.dsc to NT32 specific drivers because only NT32 specific drivers need the visual studio header files. Your feedback is appreciated. Thanks, Cinnamon Shia From: Gao, Liming [mailto:[email protected]] Sent: Wednesday, January 14, 2015 5:14 PM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Cinnamon: Another option is to change the default build option by removing /X in BaseTools/Conf/tools_def.template. If so, Nt32Pkg.dsc doesn't require the override option. Thanks Liming From: Shia, Cinnamon [mailto:[email protected]] Sent: Wednesday, January 14, 2015 4:05 PM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Hello Liming, The SVN patch is attached. Thanks! Thanks, Cinnamon Shia From: Gao, Liming [mailto:[email protected]] Sent: Wednesday, January 14, 2015 2:54 PM To: [email protected]<mailto:[email protected]> Subject: Re: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 The patch is missing. Could you help add it? From: Shia, Cinnamon [mailto:[email protected]] Sent: Tuesday, January 13, 2015 4:55 PM To: [email protected]<mailto:[email protected]> Subject: [edk2] [PATCH] NT32Pkg: Fix build errors from building secure boot with NT32 X64 Dear NT32Pkg maintainer, Please review attached patch. It fixes build errors from building secure boot with NT32 X64. Root cause: The CryptoPkg\Library\IntrinsicLib needs override MSFT build option to remove /Oi and /GL, but it doesn't work because of the build option override in Nt32Pkg.dsc. Solution: Move the build option override in Nt32Pkg.dsc to the inf files of NT32 relative drivers. Contributed-Under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia <[email protected]<mailto:[email protected]>> Thanks, Cinnamon Shia
FixBuildErrorFromBuildSecureBootWithNT32X64_r2.patch
Description: FixBuildErrorFromBuildSecureBootWithNT32X64_r2.patch
------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
