On 6 March 2015 at 09:57, Li, Elvin <[email protected]> wrote: > Hi Andrew/Samer/Ard, > Could you help review and give feedback about the update to SMBIOS > module to support 64-bit entry point and table? > > Based on your previous feedback about SMBIOS 3.0 64-bit > implementation, I provided the solution: > 1. I Introduced a new PCD PcdSmbiosEntryPointProvideMethod for > combinations below. Note: this PCD is ONLY used when SMBIOS major version in > BIOS is 3 and above. > * 0b - 32-bit entry point only > * 10b - 64-bit entry point only > * 11b - Both 32-bit and 64-bit entry point: > If these conditions below happen, we add one SMBIOS record to > 64-bit table ONLY: > a. If we find 32-bit entrypoint cannot be allocated below 4GB. > b. If we find memory below 4GB is not enough when a new > SMBIOS record is added/updated. > c. If we meet a length of record exceed 65535. As 32-bit > SMBIOS entry point defines "Maximum Structure Size" for a single record with > WORD. > d. If we find the size of entire SMBIOS table will exceed > 65535. As 32-bit SMBIOS entry point defines "Structure Table Length" for > entire SMBIOS table with WORD. > 2. I introduced a PcdSmbiosDocRev for Docrev field in 64-bit Entry > Point structure for customization. > > MdePkg: Add SMBIOS 3.0 configuration table guid. > MdeModulePkg: Add SMBIOS 64-bit entrypoint and 64-bit table for SMBIOS 3.0 > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Elvin Li <[email protected]> >
Hello Elvin, I think this is looking very good! I only spotted a typo in a comment > 'SMBIOS talbe' instead of 'SMBIOS table', other than that I have no comments. Reviewed-by: Ard Biesheuvel <[email protected]> Thanks, Ard. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
