In 1/2, it seems like the typo came from the Shell spec 2.0, but it was fixed in 2.1.
My one minor comment is that in 2/2 it could have been IsStringOfHexBytes, and trivially verified an even number of characters without the extra StrLen call later on. Series Reviewed-by: Jordan Justen <[email protected]> On 2015-03-27 17:23:04, Laszlo Ersek wrote: > Cc: Jaben Carsey <[email protected]> > > Sometimes it is useful to set UEFI variables via machine-generated UEFI > shell scripts, with the help of the SETVAR command. The hexadecimal data > string parameter of SETVAR is ideal for this purpose -- the script > generator can easily prepare such arguments --, however it turns out > that the hex data string parser of SETVAR has an unintended length > limitation. Let's lift it. > > (If the patches are deemed correct, I'd prefer to commit them myself to > SVN.) > > Thanks! > Laszlo > > Laszlo Ersek (2): > ShellPkg: UefiShellDebug1CommandsLib: fix SETVAR option summary > ShellPkg: UefiShellDebug1CommandsLib: fix hex string parsing in SETVAR > > ShellPkg/Library/UefiShellDebug1CommandsLib/SetVar.c | > 32 +++++++++++++++++++- > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | > Bin 140130 -> 140130 bytes > 2 files changed, 31 insertions(+), 1 deletion(-) > > -- > 1.8.3.1 > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
