On 04/06/15 09:06, Jordan Justen wrote: > Wow. By the looks of this, you somehow managed to create and send all > these patches with svn. I applaud your effort, but I hope you consider > looking into git for future work to save yourself time. :) > > One request I have is to make patch 1 throgh 16 all reply to patch 0. > This will keep all code reviews for the patch series in a single email > thread. > > For what it is worth, this is the basic flow for sending patches with > git: > > # Make sure no old patches are hanging around > $ rm *.patch > > # Create 0000-*.patch through 0016-*.patch > $ git format-patch --cover-letter origin/master
Let me insert the following options here: --stat=1000 --stat-graph-width=20 edk2 uses very long pathnames (as a result of deep directory structures and long filenames for both directories and regular files). The above options will prevent the diffstats included in all of the patch emails (including the blurb) from becoming worthless -- the left side column, with the pathnames, will be just as wide, but not wider, as needed, to accommodate the longest pathname, whereas the right side column, with the plus and minus signs, will be both narrow *and* useful. Thanks! Laszlo > # Manually edit 0000-*.patch > > # Send all patches & keep them in a single thread > $ git send-email *.patch > > I think these steps would be a lot better than the many tedious manual > steps with svn. > > For patches 8 and 9, I think you didn't Cc the package owners. > > -Jordan > > On 2015-04-05 20:38:31, Scott Duplichan wrote: >> Thanks for adding CorebootPayloadPkg/CorebootModulePkg. This project is the >> best solution yet to a long standing EDK2 problem: how can EDK2 code be >> tested >> on real hardware without access to the NDA reference code needed for early >> processor initialization? DuetPkg is a possibility. But DuetPkg has >> significant >> limitations and needs changes for use with most motherboards. >> >> Not stated but of great value is the fact that CorebootPayloadPkg is >> designed to work with any x86 coreboot project, not just the Intel MinnowMax >> board. For example, I am using an ECS A780GM-M3 board. This board is >> compatible >> with coreboot built for AMD Mahogany Fam10. Coreboot supports a variety of >> x86 boards so there are a lot of potential choices for running the EDK2 >> CorebootPayloadPkg. Older boards may not have enough free ROM space to >> accommodate CorebootPayloadPkg. The 1MB flash chip on the ECS A780GM-M3 board >> is just big enough to hold coreboot plus a CorebootPayloadPkg release build. >> >> This patch set adds gcc support to CorebootPayloadPkg/CorebootModulePkg. It >> also adds a few build enhancements and fixes a couple of other miscellaneous >> build problems. A change needed for running the X64 build on AMD processors >> is included. >> >> With this patch set, building succeeds with all 72 combinations of >> RELEASE/DEBUG/NOOPT, IA32/X64, and the following tool chains: DDK3790, >> VS2005, VS2008, VS2010, VS2012, VS2013, GCC44, GCC45, GCC46, >> GCC47, GCC48, GCC49. >> >> Boot testing on real hardware (ECS A780GM-M3) passes using both >> IA32 and X64 release builds from gcc44, gcc49, and VS2010. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Scott Duplichan <[email protected]> >> --- >> >> Thanks, >> Scott > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
