The patch looks good to me. Reviewed-by: Maurice Ma <[email protected]>
Thanks Maurice -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Sunday, April 05, 2015 9:21 PM To: [email protected]; Ma, Maurice; Agyeman, Prince Subject: [Patch 6/16] CorebootModulePkg: Reformat asm constant to avoid gcc assembler fail The gnu assembler doesn't allow multiple '$' in an expression. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Duplichan <[email protected]> --- Index: CorebootModulePkg/SecCore/Ia32/SecEntry.S =================================================================== --- CorebootModulePkg/SecCore/Ia32/SecEntry.S (revision 17108) +++ CorebootModulePkg/SecCore/Ia32/SecEntry.S (working copy) @@ -46,7 +46,7 @@ # # Construct the temporary memory at 0x80000, length 0x10000 # - movl ($BASE_512KB + $SIZE_64KB), %esp + movl $(BASE_512KB + SIZE_64KB), %esp # # Pass BFV into the PEI Core ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
