On 04/08/15 09:10, Ard Biesheuvel wrote: > This updates ArmVirtualizationQemu.dsc to use the MemoryInitPeilLib > implementation for virt targets. The only difference between that one > and the original one is that the original one removes memory from the > available list if it overlaps the FD region (which may be the case when > shadowing NOR flash with system RAM). Since this is never the case for > the Qemu target, this change should have no effect. In a followup patch, > we will implement more virt specific behavior in this library instance. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc > b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc > index 07ae63ada7c0..cad7353442f7 100644 > --- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc > +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc > @@ -39,6 +39,8 @@ > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf > > [LibraryClasses.common] > + > MemoryInitPeiLib|ArmPlatformPkg/ArmVirtualizationPkg/Library/ArmVirtualizationMemoryInitPeiLib/ArmVirtualizationMemoryInitPeiLib.inf > + > # Virtio Support > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf >
Instead of this patch, how about moving the similar (preexistent) resolution from "ArmVirtualizationXen.dsc" to "ArmVirtualization.dsc.inc"? In practice that would mean: - delete the resolution in "ArmVirtualizationXen.dsc", - update (redirect) the resolution in "ArmVirtualization.dsc.inc" that was added in patch #1. Otherwise, we'll end up with a resolution in the dsc include file that none of the actual platforms use, and the actual platforms will both use the same non-default resolution. What do you think? Thanks Laszlo ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
