To prevent a build failure, I think you should split up patch 1 into 2 parts, so:
Patch 1: Add PCDs to MdePkg Patch 2: Update IntelFrameworkModulePkg to use PCDs in MdePkg Patch 3: Delete PCDs from gEfiIntelFrameworkModulePkgTokenSpaceGuid By the way. Is it okay to remove the PCDs from gEfiIntelFrameworkModulePkgTokenSpaceGuid? It seems like we often copy rather than move things to prevent breaking platforms that used the old location. git will allow you to easily commit patches 1 and 2 to svn very quickly, so it is likely that people using 'svn update' will not see a build break. But, it is still bad (in my opinion) to have the build be broken after patch 1. I think there are many good reasons to try to make sure all commits don't break the build, but one good reason is to allow the git bisect command to be used. git bisect is a very cool tool that allows us to more quickly track down when bugs are introduced into the tree. -Jordan On 2015-04-21 22:37:44, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <[email protected]> > --- > IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > b/IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > index d8b845f..6afb8a0 100644 > --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > @@ -14,7 +14,7 @@ > # BDSDxe also maintain the UI for "Boot Manager, Boot Maintaince Manager, > Device Manager" which > # is used for user to configure boot option or maintain hardware device. > # > -# Copyright (c) 2008 - 2014, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.<BR> > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD > License > # which accompanies this distribution. The full text of the license may be > found at > @@ -192,12 +192,12 @@ > gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang ## > SOMETIMES_CONSUMES > ## CONSUMES > ## PRODUCES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdHardwareErrorRecordLevel > + gEfiMdePkgTokenSpaceGuid.PcdHardwareErrorRecordLevel > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow ## PRODUCES > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn ## PRODUCES > ## SOMETIMES_CONSUMES > ## SOMETIMES_PRODUCES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdPlatformBootTimeOut > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut > ## CONSUMES > ## PRODUCES > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBootState > @@ -208,12 +208,12 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand ## > SOMETIMES_CONSUMES > ## CONSUMES > ## SOMETIMES_PRODUCES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdSetupConOutColumn > + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutColumn > ## CONSUMES > ## SOMETIMES_PRODUCES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdSetupConOutRow > - > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution > ## CONSUMES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution > ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow > + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution > ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution > ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdErrorCodeSetVariable > ## CONSUMES > > [Depex] > -- > 1.9.5.msysgit.1 > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
