Thanks!. I will reformat it when checking-in. Jeff -----Original Message----- From: Justen, Jordan L Sent: Saturday, April 25, 2015 2:29 PM To: [email protected]; Fan, Jeff Subject: Re: [edk2] [PATCH v2 3/3] SourceLevelDebugPkg/DebugAgent: Add some comments and debug message
On 2015-04-22 01:25:42, Jeff Fan wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan <[email protected]> > --- > .../Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 19 > +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > index 7f59735..80fd01d 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge > +++ nt.c > @@ -1335,6 +1335,8 @@ GetBreakCause ( > if ((CpuContext->Dr6 & BIT14) != 0) { > Cause = DEBUG_DATA_BREAK_CAUSE_STEPPING; > // > + // DR6.BIT14 Indicates (when set) that the debug exception was > triggered by the singlestep execution mode. > + // The single-step mode is the highestpriority debug exception. > // If it's single step, no need to check DR0, to ensure single step > work in PeCoffExtraActionLib > // (right after triggering a breakpoint to report image load/unload). > // > @@ -2392,9 +2394,15 @@ InterruptProcess ( > // Check if this exception is issued by Debug Agent itself > // If yes, fill the debug agent exception buffer and LongJump() back to > // the saved CPU content in CommandCommunication() > + // If exception is issued when executing Stepping, will be handled in > exception handle procedure. Could you make this comment, and the comment above fit in 80 columns? Series Reviewed-by: Jordan Justen <[email protected]> > // > if (GetDebugFlag (DEBUG_AGENT_FLAG_AGENT_IN_PROGRESS) == 1) { > - DebugAgentMsgPrint (DEBUG_AGENT_ERROR, "Debug agent meet one > Exception, ExceptionNum is %d, EIP = 0x%x.\n", Vector, > (UINTN)CpuContext->Eip); > + DebugAgentMsgPrint ( > + DEBUG_AGENT_ERROR, > + "Debug agent meet one Exception, ExceptionNum is %d, EIP = 0x%x.\n", > + Vector, > + (UINTN)CpuContext->Eip > + ); > ExceptionBuffer = (DEBUG_AGENT_EXCEPTION_BUFFER *) (UINTN) > GetMailboxPointer()->ExceptionBufferPointer; > ExceptionBuffer->ExceptionContent.ExceptionNum = (UINT8) Vector; > ExceptionBuffer->ExceptionContent.ExceptionData = (UINT32) > CpuContext->ExceptionData; @@ -2604,9 +2612,16 @@ InterruptProcess ( > > default: > if (Vector <= DEBUG_EXCEPT_SIMD) { > + DebugAgentMsgPrint ( > + DEBUG_AGENT_ERROR, > + "Exception happened, ExceptionNum is %d, EIP = 0x%x.\n", > + Vector, > + (UINTN) CpuContext->Eip > + ); > if (BreakCause == DEBUG_DATA_BREAK_CAUSE_STEPPING) { > // > - // Stepping is finished, send Ack package. > + // If exception happened when executing Stepping, send Ack package. > + // HOST consider Stepping command was finished. > // > if (MultiProcessorDebugSupport()) { > mDebugMpContext.BreakAtCpuIndex = ProcessorIndex; > -- > 1.9.5.msysgit.0 > > > ---------------------------------------------------------------------- > -------- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard Learn > Process modeling best practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
