> On May 11, 2015, at 9:17 PM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > > On 2015-05-11 20:59:40, Chan, Amy wrote: >> Sorry for typo. >> The change is not only for removing a feature (EDK II NASM support), >> we also have other updates. > >> From Liming's version of your patch, this appears to be the extent of > the commit message: > > === > Basetools update for CLAN support > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Amy Chan <amy.c...@intel.org> > === > > So, one line, one typo. And no useful information about why this is > the best way to proceed. It doesn't even mention removing NASM > support. > > OvmfPkg requires NASM support, so I strongly disagree with this > change. > > Also, as Liming mentioned, we are working to *expand* our usage of > NASM in EDK II, not remove it. We eventually want to convert all IA32 > and X64 assembly code to be only use NASM source files. (It will be a > while though…)
I still wanted the option to use the .S files as the debugger support in NASM was broken. This patch seems to be doing way too many things. It is adding a CLANG target on Liniux, adding mtoc binary, and changing some of the XCODE* targets. It also looks like some merged a forked tree back into the edk2. That might explain why the NASM rules got removed. And some of the changes in the Xcode target are spacing. Actually I’d recommend not changing BaseTools/Conf/build_rule.template, not changing BaseTools/Conf/tools_def.template XCODE5 target and just testing against the edk2 tools. You will have to install iasl and mtoc in your path to make that work. If you send me the errors I can figure out what we need to fix. Like I mentioned I have a couple of changes queued up that I would like to make the XCODE5 target, so I might as well make them all together. Thanks, Andrew Fish > > -Jordan > >> -----Original Message----- >> From: Chan, Amy >> Sent: Tuesday, May 12, 2015 11:59 AM >> To: Justen, Jordan L; edk2-devel@lists.sourceforge.net; Gao, Liming >> Cc: Davis, Brad A; Chiu, Chasel; Chaganty, Rangasai V >> Subject: RE: [edk2] Basetools update for CLAN support >> >> Liming helped convert this patch to git format, you can see my first >> attached org\chg files if you want to review all the file changes. >> The change is not only for removing a feature (EDK II NASM support), we also >> have other updates. >> >> Thanks and regards, >> Amy >> >> -----Original Message----- >> From: Justen, Jordan L >> Sent: Tuesday, May 12, 2015 11:51 AM >> To: edk2-devel@lists.sourceforge.net; Gao, Liming; Chan, Amy >> Cc: Davis, Brad A; Chiu, Chasel; Chaganty, Rangasai V >> Subject: Re: [edk2] Basetools update for CLAN support >> >> Liming, Amy, >> >> I'm confused. I didn't even see the original post of the patch to >> edk2-devel. Maybe Amy is not subscribed? >> >> I don't think removing a feature (EDK II NASM support), and calling it >> 'Basetools update for CLAN support' is a good way to proceed. >> >> Maybe just install NASM instead? >> >> There was also some discussions of allowing toolchains, or toolchain >> families to choose the priority for source file extensions. Did that go >> anywhere? >> >> -Jordan >> >> On 2015-05-11 18:33:59, Gao, Liming wrote: >>> Andrew: >>> >>> I convert this patch to git format for your review. >>> >>> 1) On Mtoc tool, user can configure tools_def.txt to point its path. >>> I don't think it is necessary to integrate it into EDKII BaseTools. >>> >>> >>> >>> Thanks >>> >>> Liming >>> >>> From: Andrew Fish [mailto:af...@apple.com] >>> Sent: Tuesday, May 12, 2015 1:25 AM >>> To: edk2-devel@lists.sourceforge.net >>> Cc: Davis, Brad A; Chiu, Chasel; Chan, Amy; Chaganty, Rangasai V >>> Subject: Re: [edk2] Basetools update for CLAN support >>> >>> >>> >>> >>> >>> On May 10, 2015, at 8:30 PM, Gao, Liming <liming....@intel.com> wrote: >>> >>> >>> >>> 2) Nasm build rules have been used for the other tool chain and >>> platform. And, we also agree to use nasm in EDKII. I don't think we can >>> drop it now in the default configuration. >>> >>> 3) I don't see those flags in build_rule.txt. I am curious how use them >>> in CLANG build. >>> >>> >>> >>> Thanks >>> >>> Liming >>> >>> From: Chiu, Chasel >>> Sent: Friday, May 08, 2015 5:35 PM >>> To: Gao, Liming; Chan, Amy; edk2-devel@lists.sourceforge.net >>> Cc: Mudusuru, Giri P; Chaganty, Rangasai V; Davis, Brad A >>> Subject: RE: Basetools update for CLAN support >>> >>> >>> >>> >>> >>> See my reply. >>> >>> >>> >>> Thanks! >>> >>> Chasel >>> >>> >>> >>> >>> >>> From: Gao, Liming >>> Sent: Friday, May 8, 2015 5:23 PM >>> To: Chan, Amy; edk2-devel@lists.sourceforge.net >>> Cc: Chiu, Chasel; Mudusuru, Giri P; Chaganty, Rangasai V; Davis, Brad A >>> Subject: RE: Basetools update for CLAN support >>> >>> >>> >>> Amy: >>> >>> I have two comments. >>> >>> 1. PosixLink for EDKII BaseTools, not for third party tool. I >>> don't think it is good to add Mtoc here. [cc] in the past we put this >>> mtoc in BaseTools, we can move to other place but actually I have no >>> idea why we need mtoc to compile CLANG on MAC OS. We might can eliminate >>> it. >>> >>> >>> >>> To enable debugging we have clang compile to Mach-0 (native execution >>> format on a Mac). The mtoc tool is a Mach-O to PE/COFF conversion tool. It >>> is open sourced by Apple as part of CCTOOLS. It works like the ELF to >>> PE/COFF conversion code that is in the edk2 BaseTools. >>> >>> >>> >>> I have no problem with someone checking the binary in the tree for mtoc, >>> as it is open sourced code. >>> >>> 2. Why remove nasm build rules from build_rule.template? [cc] >>> Thunk16.nasm build failure due to "DQ 0" -> "DQ 0.0" and more errors. >>> Removed this can build S file instead and pass. >>> >>> 3. Who uses *_XCODE5_*_PLATFORM_FLAGS and >>> *_XCODE5_X64_PLINK_FLAGS? [cc] CLANG building on MAC OS. >>> >>> >>> >>> >>> >>> The PLATFORM_FLAGS originated in the ARM port. >>> >>> >>> >>> I do the maintenance to keep Xcode working. So you can send me a patch and >>> I can review it, test it and commit it. >>> >>> >>> >>> I recently made a change to our internal version of the flags and I can >>> sync that back too. I add -fcolor-diagnostics to the compiler lines as >>> this enabled color diagnostic (error messages) from clang when building >>> under the edk2. >>> >>> >>> >>> Thanks, >>> >>> >>> >>> Andrew Fish >>> >>> Thanks >>> >>> Liming >>> >>> From: Chan, Amy >>> Sent: Friday, May 8, 2015 4:48 PM >>> To: edk2-devel@lists.sourceforge.net >>> Cc: Chiu, Chasel; Mudusuru, Giri P; Chaganty, Rangasai V; Davis, Brad A; >>> Gao, Liming >>> Subject: Basetools update for CLAN support >>> >>> >>> >>> Hello all, >>> >>> >>> >>> Recently we found we need to make some changes on BaseTools to build our >>> RC with CALNG-on-MacPC: >>> >>> 1. Add one file BaseTools\BinWrappers\PosixLike\mtoc >>> >>> 2. Update BaseTools\Conf\build_rule.template >>> >>> 3. Update BaseTools\Conf ools_def.template >>> >>> Please see the attached file for detail, Password is Intel123 >>> >>> >>> >>> However the same BaseTools has been using by some customers who should >>> already complain and ask change for this... >>> >>> We are not sure whether those change is a correct, whether we can avoid >>> it by some simple build flags change. >>> >>> >>> >>> Please kindly give us some advice if you have any idea. >>> >>> >>> >>> Thanks and regards, >>> >>> Amy >>> >>> >>> ------------------------------------------------------------------------------ >>> One dashboard for servers and applications across >>> Physical-Virtual-Cloud >>> Widest out-of-the-box monitoring support with 50+ applications >>> Performance metrics, stats and reports that give you Actionable Insights >>> Deep dive visibility with transaction tracing using APM Insight. >>> >>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y_______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/edk2-devel >>> >>> > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
