Reviewed-by: Ruiyu Ni <[email protected]>
From: Tian, Feng
Sent: Wednesday, May 20, 2015 9:26 AM
To: Ni, Ruiyu
Cc: [email protected]; Tian, Feng
Subject: RE: [patch] FatPkg: Add RecoveryBlockIo2Ppi support
Thanks, Ray
I update the patch according to your comment. Please review again
Thanks
Feng
From: Ni, Ruiyu
Sent: Tuesday, May 19, 2015 14:04
To: Tian, Feng
Cc: [email protected]<mailto:[email protected]>
Subject: RE: [patch] FatPkg: Add RecoveryBlockIo2Ppi support
Feng,
Could you please refine the code to merge the UpdateBlocksAndVolumes() and
UpdateBlocksAndVolumes2() to one function? They are almost identical.
I recommend to change NotifyDescriptor to NotifyDescriptor[2] instead of adding
a new field NotifyDescriptor2 to the structure PEI_FAT_PRIVATE_DATA. It means
an array for PPIs notify.
Thanks,
Ray
From: Tian, Feng
Sent: Monday, May 18, 2015 1:06 PM
To: Ni, Ruiyu
Cc: [email protected]<mailto:[email protected]>;
Tian, Feng
Subject: [patch] FatPkg: Add RecoveryBlockIo2Ppi support
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <[email protected]<mailto:[email protected]>>
Thanks
Feng
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
